permissions-manage-files.xhtml doesn't handle bad identifiers gracefully
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
On demo.dataverse.org, currently running 5.6, if an end-user adds any extraneous characters to the URL permissions-manage-files.xhtml (ending in ?id=nnnnn) the page will render, but with no values displayed:
I open this issue because we're now on 5.3, under which intentionally modifying the passed identifier results in a 500 error (and a "Tums" moment for the admin), but testing on 5.6 shows that it still doesn't strip extraneous characters and I'm not certain of the ramifications.
If this issue is itself deemed extraneous, feel free to close it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the malformed identifier behavior on permissions-manage-files.xhtml using the URL pattern described in the issue, then trace the request handling for that page. Confirm the intended response for extraneous characters and verify that malformed identifiers no longer produce an empty page or a 500 error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100