IQSS / IQSS/dataverse

File table facet values not internationalized

Open
#8,089 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Feature: Internationalization Type: Bug
Dominant language
Java
Stars
1.1k
Forks
564
Avg merge
2d 2h
Merged PRs (30d)
29

Description

It appears that labels for the available facet values used in the files table were added to Bundle.properties in #5697 but it does not appear that they are used. The entries are in https://github.com/IQSS/dataverse/blob/81275596631630f232eac019ffe1e0342e661a9c/src/main/java/propertyFiles/Bundle.properties#L2600-L2618 but the values that appear on the page look like they are from the facet name , e.g. from https://github.com/IQSS/dataverse/blob/81275596631630f232eac019ffe1e0342e661a9c/src/main/java/edu/harvard/iq/dataverse/search/SearchConstants.java#L39-L40 for the access facet. (I didn't tract down where the types labels are coming from.)

I've seen this in the embargo PR (based on current develop) and it appears to be the case at Scholar's Portal as well (see below).

image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the facet-label entries in src/main/java/propertyFiles/Bundle.properties and the access facet constants in src/main/java/edu/harvard/iq/dataverse/search/SearchConstants.java. Trace how the files-table facet values are assembled and compare them with the localized entries, including the type labels. Done means the available facet values on the files table use translated labels.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.