Decoupling TSV metadata schema parsing from API endpoint
Open
@poikilotherm is already working on this.
Since Sep 1, 2021.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
Currently, any TSV file loaded into a Dataverse instance flows through DatasetFieldServiceApi.loadDatasetFields().
This method isn't just the endpoint, it also contains all the code to parse and convert the TSV into living model objects.
This needs to be torn apart:
- Enable proper testing of the parser
- Enable reading TSV metadata schemas during unit & integration testing. A bare necessity for #5989
- Enable reading the files not only via API endpoint:
- Possibility to move the code into a reusable module outside main codebase
- Load TSVs from disk/WAR during startup and bootstrap (Hello, #5361)
- Enable validation on load
- Refactor some dusted code
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.