Enhance branding configuration (& refactor)
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
Relates to #7649 and #7424
Currently, BrandingUtil does not do much more than handing back what you gave it. #3611 and #2710 where about options to override things.
So let's create new MPCONFIG variables:
dataverse.branding.installation.name, defaulting to the root Dataverse collection namedataverse.branding.support.name, defaulting to root Dataverse collection name +contact.supportbundle string as is nowdataverse.branding.support.mail, defaulting todataverse.mail.system.fromintroduced for #7424
These can be either injected via CDI or retrieved programmatically via Config.getValue().
Easiest way to go IMHO: add a LookupConfigSource that has access to the necessary database services and might be used for other stuff down the road.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating BrandingUtil and the existing dataverse.mail.system.from configuration from #7424, then inspect how Config.getValue() and CDI expose configuration values. Compare the requested defaults with the root Dataverse collection name and the contact.support bundle string; done means the three MPCONFIG variables and the proposed LookupConfigSource behavior are covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100