IQSS / IQSS/dataverse

MPCONFIG: identify non-static settings

Open
#7,639 5 comments 0 reactions 1 assignee View on GitHub

@poikilotherm is already working on this.

Since Feb 25, 2021.

Component: Code Infrastructure Feature: Admin Guide Feature: API Feature: Developer Guide Feature: Installation Guide Feature: Installer Type: Feature User Role: Sysadmin
Dominant language
Java
Stars
1.1k
Forks
564
Avg merge
2d 2h
Merged PRs (30d)
29

Description

As part of the community call on 2021-02-23, @scolapasta mentioned that historically the database settings had been introduced to make config changes during runtime easier without restarting the deployment/application server. Notes for the talk, Slides of the talk, Recording of the talk

Before migrating all JVM options and Database settings to be configurable via MicroProfile Config, we should identify which settings are crucial to be updated without a restart.

Please note: this does not hold us back from still using MicroProfile Config for those. We just have to make extra sure and double check that the code re-reads any updated setting instead of injecting it statically (either by accessing it programmatically or going for injecting via Provider<>). We should also add a statement to the docs about this fact and which sources not to use then.

So, looking at you @donsizemore, @pdurbin, @landreev, @scolapasta and so many others with experience in running the service: please feel free to add your favorite dynamic setting/s below. I will edit this first comment with an updated list for each.

If there is a JVM option that hasn't been dynamic before, but you feel it should BECOME dynamic, please also comment below.

Thank you folks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.