Get rid of JVM option dataverse.fqdn and validate dataverse.siteUrl on boot
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
During my time with Dataverse and being on the IRC channel every day, I noticed a lot of confusion, errors and waste of time created by two things:
dataverse.fqdnanddataverse.siteUrlsettings are confusing when to use which, what are the consequences of their use etc. They get mixed up pretty much.dataverse.siteUrlnot containing a proper URL, but only the FQDN part.
I propose with the strong support of @pdurbin and @donsizemore that
- we should remove
dataverse.fqdnand instead concentrate on one, non-confusing settingdataverse.siteUrl. - That setting should be validated at boot time, so people fail early when they don't use a proper URL for it.
This is a rather small thing to do. It actually will reduce code complexity, make the docs more precise and easier to understand for newbies. I suggest this is a small issue and volunteer to create a PR.
Back in the days the docs had been extended to better explain the usage, see #4887
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by locating definitions and usages of dataverse.fqdn and dataverse.siteUrl, then trace the application boot configuration path. Done means dataverse.fqdn is removed, dataverse.siteUrl is validated as a proper URL at boot, and the affected documentation and tests reflect the single setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100