IQSS / IQSS/dataverse

PID failure logs only seems to work with api calls

Open
#12,583 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Bug
Dominant language
Java
Stars
1.1k
Forks
564
Avg merge
2d 2h
Merged PRs (30d)
29

Description

We recently enabled the enable-pid-failure-log feature flag (Feature flag:
-Ddataverse.feature.enable-pid-failure-log=true) in our QA and Prod sites .. and I see logs being created.

I did a bunch of testing to see what it is logging with various methods of requesting an invalid DOI. The documentation and PR for enable-pid-failure-log suggest that failed dataset/file PID lookups should be logged. In Dataverse 6.10.1, failed lookups via /api/datasets/:persistentId are logged, but failed lookups via /dataset.xhtml?persistentId=... are not. Is this the intended behavior, or should the JSF landing page also generate PID failure log entries?

What steps does it take to reproduce the issue?
curl -i "https:///api/datasets/:persistentId/?persistentId=doi:10.5072/FK2/" (logs)
curl -i "https:///dataset.xhtml?persistentId=doi:10.5072/FK2/" (does not log)
OR:
from browser:
https:///api/datasets/:persistentId/?persistentId=doi:10.5072/FK2/ (logs)
https:///dataset.xhtml?persistentId=doi:10.5072/FK2/ (does not log)

  • When does this issue occur?
    when a bad PID is entered using the dataset landing page URL

  • What happens?
    does not create log in PIDFailures_.log

Which version of Dataverse are you using?
v6.10.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the two requests described for the enable-pid-failure-log flag, comparing the API endpoint with the dataset.xhtml landing page. Trace the PID lookup and failure logging paths for each entry point, then verify whether an invalid landing-page PID creates a PIDFailures_.log entry as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.