IQSS / IQSS/dataverse

Guestbook Response JSF popup Cancel button not working

Open
#12,205 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Size: 10 Type: Bug
Dominant language
Java
Stars
1.1k
Forks
564
Avg merge
2d 2h
Merged PRs (30d)
29

Description

What steps does it take to reproduce the issue? Create a Dataverse/Dataset and upload files. Add a Guestbook with required fields to the Dataset. Publish

  • When does this issue occur? Try to download a file and you will see the Guestbook Response dialog. Press cancel and nothing happens.

  • Which page(s) does it occurs on? Dataset page when trying to download an image

  • What happens?

  • To whom does it occur (all users, curators, superusers)? All

  • What did you expect to happen? Dialog should close. The workaround is to hit the browser's back button.

Which version of Dataverse are you using? 6.9

Any related open or closed issues to this bug report?

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

Are you thinking about creating a pull request for this issue?
Help is always welcome, is this bug something you or your organization plan to fix?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this on the Dataset page by creating a Dataverse/Dataset, adding a required Guestbook, publishing, downloading an image, and pressing Cancel in the Guestbook Response dialog. Start by locating the JSF popup implementation used there; done means the Cancel button closes the dialog for all users without requiring the browser Back button.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.