IQSS / IQSS/dataverse

Wording of 404static.xhtml is not generic

Open
#12,183 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Bug
Dominant language
Java
Stars
1.1k
Forks
564
Avg merge
2d 2h
Merged PRs (30d)
29

Description

Hi!
Creating this as a follow-up from https://dataverse.zulipchat.com/#narrow/channel/378866-troubleshooting/topic/404static.2Exhtml.20file . 404static.xhtml file introduced in v6.0 is not generic and contains harvard specific link and text:

Image

So, we suggest following changes to 404static.xhtml to make it more generic:

  1. Remove following code snippet as it is Harvard specific:


    Copyright © 2023, The President & Fellows of Harvard College | Privacy Policy


  2. In the file, #{bundle['footer.dataverseProject']} is used for Header. Instead can use #{bundle['dataverse']}:
    Reference to code:


    <h:outputFormat class="navbar-brand custom-logo" value="#{bundle['footer.dataverseProject']}"/>

  3. The logo image at the bottom could be specified as "./resources/images/dataverseproject_logo.png" instead of "https://cdn.rawgit.com/IQSS/dataverse/develop/src/main/webapp/resources/images/dataverseproject_logo.png" .
    Some installations like us may face CSP restriction to have external link references as shown below:

Image

The missing alert-danger spec for error message is also due to this external reference URL of bootstrap.min.css and bootstrap-theme.min.css in 404static.xhtml file.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading 404static.xhtml and review the footer, bundle keys, logo reference, and external CSS URLs called out in the issue. Remove the Harvard-specific content, use the requested generic text and local logo path, and verify the page has no external references that prevent the error styling from appearing under CSP.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, css, html
Domain
frontend, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.