Metadata field "displayFormat" is wrongly applied to facet values
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
What steps does it take to reproduce the issue?
-
Have a metadata block activated which contains at least one facetable field with a non-default
displayFormat, e.g.authorAffiliationin the citation block is facetable and has display format(#VALUE)cityin the geospatial block is facetable and has display format#VALUE,
-
Have a collection with that facet turned on
-
Create a dataset with a value in that facetable field
-
View the facets on the collection page, which look odd due to superfluous commas or parentheses:
-
city:(see here: https://demo.dataverse.org/dataverse/veratest)
-
authorAffiliation: -
The field
topicClassificationincludes double parentheses, not sure why, but I think it might also be related:(see here: https://demo.dataverse.org/)
-
Which version of Dataverse are you using?
v6.8 and v6.9
Any related open or closed issues to this bug report?
Did not find any open issues.
I think the bug was introduced by https://github.com/IQSS/dataverse/pull/11750 with this code change:
Are you thinking about creating a pull request for this issue?
Possibly yes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the displayFormat change in pull request #11750 and reproduce the issue on the collection page using facetable city or authorAffiliation fields from the citation or geospatial metadata blocks. Done means facet values render without the metadata field's extra commas or parentheses, including checking topicClassification for the reported double parentheses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100