IQSS / IQSS/dataverse

bad identifier throws internal server error

Open
#11,942 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Bug
Dominant language
Java
Stars
1.1k
Forks
564
Avg merge
2d 2h
Merged PRs (30d)
29

Description

What steps does it take to reproduce the issue?
If you try to navigate to a dataset, then tweak the prefex (doi) to the identifier you will end up on a page that shows there was an internal error. For example, change doi to doix. (I do want to acknowledge that if you tweak the last part of the doi, you will get a not found error - which is correct)

  • When does this issue occur?
    In the event of an invalid identifier (prefix of doi being messed up)

  • Which page(s) does it occurs on?
    Any dataset page

  • What happens?
    You get an error page that looks like this:

Image
  • To whom does it occur (all users, curators, superusers)?
    All users

  • What did you expect to happen?

I expected it to say that the record was not found rather than have an internal server error show up in the UI.
Internal server errors make it seem like the server failed, but in this case it was a user error. Seems like the system could send a more useful message to the user pointing them to examine the identfier more closely.

Which version of Dataverse are you using?

version 6.6

Any related open or closed issues to this bug report?

Not that I'm aware of
Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

Are you thinking about creating a pull request for this issue?
Help is always welcome, is this bug something you or your organization plan to fix?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from a dataset page by changing the DOI prefix to an invalid value such as “doix,” then trace the dataset identifier handling and error response. Done means an invalid prefix produces a not-found or similarly useful user-facing response instead of an internal server error; no specific files or tests are named.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.