IQSS / IQSS/dataverse

Incosistencies in notification creation about access right changes

Open
#11,666 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Bug
Dominant language
Java
Stars
1.1k
Forks
564
Avg merge
2d 2h
Merged PRs (30d)
29

Description

What steps does it take to reproduce the issue?

Our installation (Dataverse 6.1 based) is set to send notifications about user role changes. These changes can occur in several ways, but some cases are not handled consistently with this setting.

Manual role assignment in an existing dataverse (works as expected):

  • An email is sent to the person who received the role
  • A notification is sent to the person who received the role

Manual role removal (works as expected):

  • An email is sent to the person from whom the role was removed
  • A notification is sent to the person from whom the role was removed

Role assignment via API in an existing dataverse – https://guides.dataverse.org/en/latest/api/native-api.html#assign-a-new-role-on-a-dataverse-collection (notifications missing):

  • No email is sent to anyone
  • No notification is sent to anyone

Dataverse creation where someone automatically receives the admin role (InheritParentRoleAssignments set to true, notifications missing):

  • The person who created the dataverse receives an email about the creation
  • The person who automatically received the role does not receive an email
  • The person who automatically received the role does not receive a notification
  • When does this issue occur?
    Always.

  • Which page(s) does it occurs on?
    na.

  • What happens?
    I expect notifications (email + user notifications) to be triggered, but they are inconsistent: API calls behave differently compared to UI operations, and notifications are also missing for automatic role assignments during dataverse creation.

  • To whom does it occur (all users, curators, superusers)?
    All users.

  • What did you expect to happen?
    Consistent notifications according to the system configuration.

Which version of Dataverse are you using?
6.1, but we have observed that API calls bypass the notification logic in newer versions as well.

Any related open or closed issues to this bug report?

Possibly related to this issue, which was closed as a misformatted feature request:
https://github.com/IQSS/dataverse/issues/4043

Screenshots:
na.

Are you thinking about creating a pull request for this issue?
No.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the role-assignment paths described in the issue: manual UI assignment, the native API assignment, and automatic assignment during dataverse creation. Trace where email and user notifications are triggered, then verify that configured notifications are sent consistently for each access-right change.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, authorization, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.