Account creation confirmation email should include support email, not system email
Open
Beginner friendly
Nobody has claimed this yet.
Feature: Notifications
Type: Bug
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
The template is given the output from getSystemAddress instead of getSupportAddress on the two lines starting at the link below:
case CREATEACC:
String accountCreatedMessage = BundleUtil.getStringFromBundle("notification.email.welcome", Arrays.asList(
BrandingUtil.getInstallationBrandName(),
systemConfig.getGuidesBaseUrl(),
systemConfig.getGuidesVersion(),
BrandingUtil.getSupportTeamName(getSystemAddress().orElse(null)),
BrandingUtil.getSupportTeamEmailAddress(getSystemAddress().orElse(null))
It seems like functions called getSupportTeam* should take the output of getSupportAddress() not getSystemAddress().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/main/java/edu/harvard/iq/dataverse/MailServiceBean.java at the CREATEACC case and the two lines around L597. Review how the welcome email arguments are assembled, then verify that the support-team fields use the support address and that the account-creation confirmation shows the support email.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100