Feature Request: move @DataSourceDefinition from class annotation to web.xml
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
Overview of the Feature Request
Unfortunately, we cannot make the pool sizes and other integer values configurable using MPCONFIG when using the @DataSourceDefinition annotation on DataSourceProducer.class.
The only way around that is by moving the definition to web.xml, as this gets parsed by Payara first. This way people don't need to setup the connection (as in the old days) but also have full flexibility with regards to pool sizing.
What kind of user is the feature intended for?
Sysadmin
What inspired the request?
Talking to @landreev and how they struggle in Harvard DV with the pool size.
What existing behavior do you want changed?
Extend the configurability of pool sizes for the database connections.
Any brand new behavior do you want to add to Dataverse?
Nope
Any open or closed issues related to this feature request?
#11556
Are you thinking about creating a pull request for this feature?
Probably will do.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate DataSourceProducer.class and the web.xml datasource definition, then inspect how Payara parses them and how MPCONFIG currently supplies pool sizes. Confirm that moving @DataSourceDefinition to web.xml preserves the existing connection setup while making integer pool settings configurable; add or update relevant tests if the repository identifies them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, database
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100