bug: Dataverse adds deaccessioned datasets to the sitemap
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
I noticed that our sitemap contains a bunch of deaccessioned datasets.
For example, this one has no business being on the sitemap:
https://dataverse.harvard.edu/dataset.xhtml?persistentId=doi:10.7910/DVN/0EIWIN
There are 500+ more.
It appears that the sitemap-generating code makes an effort to skip deaccessioned datasets. However it relies on
if (!dataset.isReleased() || dataset.isHarvested() || dataset.isDeaccessioned()) {
continue;
}
and dataset.isDeaccessioned() thinks that dataset is NOT deaccessioned if it has a draft.
It should follow the same logic/use the same code as reExportAll.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the sitemap-generating code and the implementation of dataset.isDeaccessioned(), then compare both with the reExportAll logic mentioned in the issue. Verify how released datasets with drafts are classified and confirm that deaccessioned datasets no longer appear in the sitemap, including the example dataset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100