Dataset thumbnail broken after metadata edit
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 564
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 29
Description
What steps does it take to reproduce the issue?
Due to #5621, actions like editing metadata after a dataset has auto-assigned a thumbnail from one of its image files cause the thumb to break and then be recorded as failed afterwards.
The root cause appears to be the call to getDatasetThumbnail at https://github.com/IQSS/dataverse/blob/5ba74e8a8e75fecec7f4b477abb920453212c53e/src/main/webapp/dataset.xhtml#L89, which, because the ImageThumbConverter.DEFAULT_PREVIEW_SIZE is not available, attempts to getDatasetThumbnail(0) which then fails.
Which version of Dataverse are you using?
6.3 - confirmed to exist on beta
PR to follow
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/main/webapp/dataset.xhtml at the getDatasetThumbnail call described in the issue, then inspect ImageThumbConverter.DEFAULT_PREVIEW_SIZE and the getDatasetThumbnail(0) path. Reproduce the failure by editing metadata on a dataset whose thumbnail was auto-assigned from an image, and confirm that the thumbnail no longer breaks or becomes recorded as failed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100