IQSS / IQSS/dataverse-frontend
Embargoed label missing on Dataset page
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 31
- Forks
- 26
- Avg merge
- 4d 13h
- Merged PRs (30d)
- 4
Description
When a Dataset contains an embargoed file, the Embargoed Label is shown in the JSF version of the page, but not the SPA.
To reproduce
- Update your Dataverse instance to allow embargoes, for example:
curl -X PUT -d 24 http://localhost:8000/api/admin/settings/:MaxEmbargoDurationInMonths - Create a dataset in Draft mode
- Add a file to the dataset
- In the File Edit Options, choose embargo, and set and embargo date
- Publish the file
- For a logged in or not logged in user, the 'Embargoed' label should appear in the Dataset Page, and in the Dataset card on the Home Page.
JSF:
The embargo information is not returned from getDataset useCase, it's only in the file data, so it looks like this will require an update to js-dataverse library.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the SPA Dataset Page and the Dataset card on the Home Page, then trace the getDataset use case and the file data returned for embargoed files. Check the js-dataverse library boundary, since the issue notes that getDataset does not return embargo information. Done means the Embargoed label appears for logged-in and anonymous users in both SPA locations when a dataset contains an embargoed file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100