IPGP / IPGP/webobs

replace XML findvalue ⇒ findvalues / findnode ⇒ findnodes

Open
#126 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Perl
Stars
21
Forks
12
PR merge metrics
No merged PRs in 30d

Description

In the XML2 module we have redundant functions: findvalue/findvalues and findnode/findnodes.
the couple's first one returns the first element found while the couple's econd returns a complete array of all element found.

It might be relevant to replace all the findvalue/findnode calls with findvalues[1]/findvalues[1] and thus delete findvalue/findnode.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the XML2 module by locating the definitions and all call sites of findvalue, findvalues, findnode, and findnodes. Check whether the singular calls can be replaced consistently, then verify that the redundant singular functions and their usages are removed without changing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.