INDAPlus21 / INDAPlus21/murnion-task-10

Pass

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Prolog
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

**Very well done Felix!**

You code is really good! I enjoyed picking it apart. Although, it can be done without a cut (`!`).

I perticulary enjoy your utilisation of logical features, epecially `neighbour`:
```prolog
neighbour(Row1, Column1, Row2, Column2) :-
(Column1 = Column2,
(Row2 is Row1 + 1; Row2 is Row1 - 1);
Row1 = Row2,
(Column2 is Column1 + 1; Column2 is Column1 - 1)).
```

Thanks for your hard work!

Educational read: https://www.metalevel.at/prolog/fun

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue contains praise and a suggestion about removing the Prolog cut, but names no file, test, or entry point. Start by locating the shown neighbour/Pass implementation; completion would require a concrete agreed change and verification criteria.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.