INDAPlus21 / INDAPlus21/emilhul-task-7

Pass

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Well done Emil!

I like your code!

My only objection is your use of heap allocation in summera_tal.c. Stack allocation is only dangerous if a pointer to such data is returned from the procedure in questioned, not if the pointer is used as argument. Yes, some IDE C-extensions will give warnings for non-constant stack allocation sizes, but such are allowed by the ISO C99 standard. The ISO C90 standard however whould, in case of int numbers[ammount_of_numbers_to_add];, produce:

summera_tal/main.c: In function ‘main’:, not dynamic array.
summera_tal/main.c:15: warning: ISO C90 forbids variable length array ‘ammount_of_numbers_to_add’

Otherwise your code is simple and minimalistic, which is easy for me :)

Keep it up!

CIA – Computer Industry Acronyms

CD-ROM: Consumer Device, Rendered Obsolete in Months
PCMCIA: People Can’t Memorize Computer Industry Acronyms
ISDN: It Still Does Nothing
SCSI: System Can’t See It
MIPS: Meaningless Indication of Processor Speed
DOS: Defunct Operating System
WINDOWS: Will Install Needless Data On Whole System
OS/2: Obsolete Soon, Too
PnP: Plug and Pray
APPLE: Arrogance Produces Profit-Losing Entity
IBM: I Blame Microsoft
MICROSOFT: Most Intelligent Customers Realize Our Software Only Fools Teenagers
COBOL: Completely Obsolete Business Oriented Language
LISP: Lots of Insipid and Stupid Parentheses
MACINTOSH: Most Applications Crash; If Not, The Operating System Hangs
AAAAA: American Association Against Acronym Abuse.
WYSIWYMGIYRRLAAGW: What You See Is What You Might Get If You’re Really Really Lucky And All Goes Well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The feedback refers to summera_tal.c and summera_tal/main.c, but it does not define a concrete change to make. Read those files to determine whether allocation should be adjusted, then confirm the program still builds and behaves as before; the issue provides no explicit done criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.