INDAPlus21 / INDAPlus21/eliasfl-task-7

Pass

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

**Very well done Elias!**

I like your code!

My only objection is your use of heap allocation in `sumsort.c`. Stack allocation is only dangerous if a pointer to such data is returned from the procedure in questioned, not if the pointer is used as argument. Yes, some IDE C-extensions will give warnings for non-constant stack allocation sizes, but such are allowed by the ISO C99 standard. The ISO C90 standard however whould, in case of `int numbers[size];`, produce:
```
sumsort/sumsort.c: In function ‘main’:, not dynamic array.
sumsort/sumsort.c:14: warning: ISO C90 forbids variable length array ‘size’
```

Keep it up!

> A programmer is walking along a beach and finds a lamp. He rubs the lamp, and a genie appears. “I am the most powerful genie in the world. I can grant you any wish, but only one wish.”
>
> The programmer pulls out a map, points to it and says, “I’d want peace in the Middle East.”
>
> The genie responds, “Gee, I don’t know. Those people have been fighting for millennia. I can do just about anything, but this is likely beyond my limits.”
>
> The programmer then says, “Well, I am a programmer, and my programs have lots of users. Please make all my users satisfied with my software and let them ask for sensible changes.”
>
> At which point the genie responds, “Um, let me see that map again.”

Contributor guide

No contributing guide indexed for this repository

Research direction

The feedback mentions heap allocation in sumsort/sumsort.c, but it does not request a specific change or define acceptance criteria. Read that file and the task requirements first, then seek maintainer clarification on whether allocation should be changed and what tests should demonstrate completion.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.