INDAPlus21 / INDAPlus21/azeezd-task-10

Pass

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Prolog
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

**Very well done Azeez!**

You code is really good! My only comment is on your slightly excessive love for paranthesises. Readability formatting is all personal preference. I find yours to be a little confusing. In the future, your code will depend on whatever your team or company deems worthy. Until then, find a formatting that your are confortable with others reading; something that makes you look good.
_Your code_:
```prolog
((This_Stone = e);
((This_Stone = Stone),
Down is Row + 1,
Up is Row - 1,
Right is Column + 1,
Left is Column - 1,(

search_for_liberty(Up, Column, Board, This_Stone, [[Row, Column] | Visited]);
search_for_liberty(Down, Column, Board, This_Stone, [[Row, Column] | Visited]);
search_for_liberty(Row, Left, Board, This_Stone, [[Row, Column] | Visited]);
search_for_liberty(Row, Right, Board, This_Stone, [[Row, Column] | Visited])))).
```
_Airy formatting with less parathesises_:
```prolog
(
This_Stone = e;
(
This_Stone = Stone,

Down is Row + 1,
Up is Row - 1,
Right is Column + 1,
Left is Column - 1,

(
search_for_liberty(Up, Column, Board, This_Stone, [[Row, Column] | Visited]);
search_for_liberty(Down, Column, Board, This_Stone, [[Row, Column] | Visited]);
search_for_liberty(Row, Left, Board, This_Stone, [[Row, Column] | Visited]);
search_for_liberty(Row, Right, Board, This_Stone, [[Row, Column] | Visited]
)
)
).
```

Thanks for your hard work!

Educational read: https://www.metalevel.at/prolog/fun

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue contains formatting feedback and a Prolog example, but names no file, test, or concrete change to make. First identify the source file containing search_for_liberty/5, then confirm whether formatting alone is intended. Done should be defined as an agreed, consistently formatted version that still passes the repository's checks.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.