INDAPlus21 / INDAPlus21/azeezd-sockets

Pass

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Very well done Azeez!

Fancy chat client and pretty server log! I only noticed that the /exit command may have some issues. The client also doesn't terminate upon exit.

[LOGS...]
220502 21:06:35 | ERR: Error "An existing connection was forcibly closed by the remote host. (os error 10054)" reading from client [::1]:60165. Closing thread220502 21:06:35 | REQ: CMD nia /exit
220502 21:06:35 | ERR: Error while removing client nia "Client does not exists in list"
220502 21:06:38 | ERR: Error "An existing connection was forcibly closed by the remote host. (os error 10054)" reading from client [::1]:60164. Closing thread220502 21:06:38 | REQ: CMD mia /exit
220502 21:06:38 | ERR: Error while removing client mia "Client does not exists in list"
[CTRL + C]
PS C:[...]>

I may also have split the long init function of Server, like you have done in Client. Otherwise, fantastic done!

Remember:

Keep it up!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the /exit behavior from the issue and inspect the client exit handling alongside the Server and Client init functions. Done means the client terminates on /exit and the server removes clients without the logged connection or missing-client errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.