INDAPlus21 / INDAPlus21/antonul-sorting

Pass

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

**Well done Anton!**

_SORRII Anton. I'm stepping back from my initial harsh comment below. I've come to realise that my assignment instructions are open for missinterpretation. Since you made a good job of completing parts of the assignment, you gain a Pass._

Not only did you give me pesky programming for depricated estetare, you pushed substandard formatting and poor inline documentation; not good; not worthy. And where is your implementation of selection sort and merge sort?

~~Lets comprimise; I'll give you _Pass_ if you simply submit an implementation of selection sort and merge sort, without the necessary visualisation logic for them.~~

Lastly, nice pancake sort.

#### Notes on your code:

I notice that you do not make use of the full extent of javascript for-loops.

_Standard for-loop_:
```js
for (let i = 0; i < array.length; i++) {/*...*/}
```
_for-loop over index range_:
```js
for (let i in array) {/*...*/}
```
_for-loop over elements_:
```js
for (let elem of array) {/*...*/}
```

Have you considered using arithmetic values in arithmetic expressions to avoid code douplication?

_Your code_:
```js
if (x%2 == 0) {
for (let i = 0;i <= ofiInsert[x]; i++) {
fillNumberRed(actionsInsert[x][i],i);
}
}
else {
for (let i = 0;i <= ofiInsert[x-1]; i++) {
fillNumberRed(actionsInsert[x][i],i);
}
}
```
_No douplications_:
```js
for (let i = 0;i <= ofiInsert[x - (x % 2)]; i++) {
fillNumberRed(actionsInsert[x][i],i);
}
```

Nice! I actually did not know of this syntax, `[array[start], array[i]] = [array[i], array[start]];`.

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue names no files, tests, or entry points; it consists of assignment feedback and JavaScript examples. The selection-sort and merge-sort request is crossed out, and the issue grants a Pass, so there is no current completion target to verify.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.