INCATools / INCATools/ontology-access-kit

Chore: Gilda annotate changes return data format in release 1.5.0

Open
#854 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
198
Forks
35
Avg merge
3d 4h
Merged PRs (30d)
1

Description

In Gilda==1.5.0 annotate was changed to return an object instead of a tuple, so the following line fails.

https://github.com/INCATools/ontology-access-kit/blob/aaede8e497e98fe7677e82730eeb56039241ac3b/src/oaklib/implementations/gilda.py#L78

Currently we downgrade to Gilda<1.5 to avoid this

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/oaklib/implementations/gilda.py around line 78 and compare the annotate return format in Gilda 1.5.0 with the current handling. Update the integration so Gilda 1.5.0 works without the current Gilda<1.5 downgrade, then run the relevant project tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.