INCATools / INCATools/ontology-access-kit
Return similarity object when doing term set similarity with semsimian
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 198
- Forks
- 35
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 1
Description
Current Monarch work would benefit from having semsimian return an empty object (or something in the expected form, at least) as a result for termset similarity rather than a NotImplementedError.
In practice this will be identical to the result returned from the stock termset similarity comparison, since it's using the same data model, and in the slightly longer term we'll have a complete set of similarity methods implemented anyway.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the semsimian termset similarity entry point and compare its result shape with the stock termset similarity comparison. Confirm the expected empty similarity object or equivalent data model, then verify that semsimian no longer raises NotImplementedError and returns that form for termset similarity.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100