INCATools / INCATools/ontology-access-kit

Add parameter `drop_dangling_nodes` in oi.relationships()

Open
#348 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
198
Forks
35
Avg merge
3d 4h
Merged PRs (30d)
1

Description

This issue arises from the process of accelerating the edge file generation in this PR: https://github.com/INCATools/oakx-grape/pull/15

While generating edge files with s, p and o, dangling nodes may not be helpful for further analysis. It would be nice to have an option to drop them or use them by indication of a flag: `drop_dangling_nodes`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the `oi.relationships()` entry point and review the edge-file generation context in oakx-grape PR 15. Determine how dangling nodes are identified and how the new `drop_dangling_nodes` flag should affect the returned relationships; done means the option is supported and its behavior is covered by relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.