INCATools / INCATools/ontology-access-kit

Provide more informative error messages if the input for SqlImplementation is not a valid sqlite file

Open
#223 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
198
Forks
35
Avg merge
3d 4h
Merged PRs (30d)
1

Description

currently if we pass in something invalid to SqlImplementation, it will not complain until *after* an operation is performed, rather than at connection/instantiation time

furthermore, the stack trace from sql aclhemy can be confusing - see #212

we should fail early with bad SqlImplementation connections (and with implementations in general)

Contributor guide

Open the contributing guide

Research direction

Locate the SqlImplementation entry point and reproduce how an invalid SQLite input is accepted until an operation runs. Inspect the existing connection and implementation tests, then verify that invalid inputs fail during instantiation with an informative error rather than a confusing SQLAlchemy traceback.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sqlalchemy, sqlite
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.