INCATools / INCATools/dosdp-tools

Feature request: --strict-vars true

Open
#208 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
33
Forks
5
PR merge metrics
No merged PRs in 30d

Description

I got cold feet for allowing the main vars (used for logical axioms) to be missing. This can indicate a much deeper error in the client setup, and I am handling now cases with 200 patterns where I would probably never notice one or two patterns not generating the axioms they should. Not too worried about data_vars and data_list_vars. I really care about vars, and only `vars`. I hereby ask for a new parameter: --strict-vars true that lets dosdp tools fail hard if one of the vars cant be found.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by tracing command-line parameter parsing in the dosdp tools and the existing handling of missing vars. Done means --strict-vars true is accepted and causes the tools to fail when a vars entry cannot be found, without requiring the same behavior for data_vars or data_list_vars.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
cli, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.