INCATools / INCATools/dosdp-tools

DOSDPT reports missing columns when missing values

Open
#205 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
33
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Zero priority but fast one to fix: If the tsv file is empty, DOSDPT currently warns:

```
2020.02.23 11:09:00 [WARN] org.monarchinitiative.dosdp.cli.Generate.$anonfun:56:51 - Input is missing column for pattern variable
```

Should be "no values".

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the warning with an empty TSV file, then inspect the DOSDPT CLI path that emits the message, identified in the report as Generate. Confirm the empty-input case is treated as having no values and verify that the warning uses "no values" rather than reporting a missing column.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.