IMGIITRoorkee / IMGIITRoorkee/placement-flutter

Show an empty state on the All Companies tab

Open Beginner friendly
#52 0 comments 0 reactions 0 assignees View on GitHub
bug P1
Dominant language
Dart
Stars
3
Forks
10
Avg merge
8d 21h
Merged PRs (30d)
4

Description

**Problem**

The All Companies tab handles a null list but has no empty-list branch, so it renders a blank white screen. Its sibling tab handles this correctly.

This is visible right now: the backend returns an empty queryset for any candidate whose season is not active, which with the season over is currently every student.

**Where**

- `lib/views/ProfilesForAllView.dart:35-38` (null branch only, no `isEmpty`)
- `lib/views/ProfilesForMeView.dart:35-40` (correct: has the `isEmpty` branch)
- Backend: `omniport-app-placement-and-internship/utils/filters.py:14-22`

**Expected**

"No companies open right now" rather than a blank page.

**Fix sketch**

- Add the `isEmpty` branch, matching `ProfilesForMeView`.

Related to #28, which is about the wording of the sibling tab's empty message.

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare lib/views/ProfilesForAllView.dart:35-38 with the isEmpty branch in lib/views/ProfilesForMeView.dart:35-40. Add the matching empty-list state to the All Companies tab, using the expected "No companies open right now" message. Verify that an empty backend result no longer renders a blank page.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart, flutter
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.