IHE / IHE/DEV.SDPi

Minor history service things

Open
#577 5 comments 0 reactions 2 assignees View on GitHub

@d-gregorczyk is already working on this.

Since Sep 4, 2026.

Comment Review
Dominant language
Kotlin
Stars
17
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Section Number

2:A.2.8.1.4:

  • missing description for FollowMdsLang
  • FollowMdsLang is optional but has no implied value; presumably false?
  • Interaction between FollowMdsLang and LanguageFilter not specified (e.g., what if FollowMdsLang is true and LanguageFilter includes a language that the Mds isn't using; what if there is partial overlap, etc).
  • Do the handle and report filters apply to the initial mdib as well=>presumably not.
  • For consistency with 20701, handle filter hint could include sequenceid and instance id

Figure 2:A.4.4-1:
The anonymous local type used for the ReportFilterType causes some serializes to generate inefficient memory allocation for the optional report filter. Suggest creating a named type:

<xsd:simpleType name="ReportFilterType">
    <xsd:list itemType="hm:ReportTypeType"/>
</xsd:simpleType>

<xsd:element
    name="ReportFilter"
    type="hm:ReportFilterType"
    minOccurs="0"
    maxOccurs="1"/>

Priority

  • Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.

Issue

Describe your issue. Don't write a book, but do include enough to indicate what you see as a problem.

Proposed Change

As above.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.