HyperPigeon / HyperPigeon/Eldritch-Mobs
[1.18.2] onlyDropLootIfKilledByPlayers not respecting Fake Player Kills
- Dominant language
- Java
- Stars
- 8
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
With onlyDropLootIfKilledByPlayers being true, it doesn't respect Fake player kills from other mods with their own fakeplayerAPI.
Indrev Fake Player class:
me.steven.indrev.blockentities.farms.SlaughterBlockEntity
Kibe Fake Player class:
io.github.lucaargolo.kibe.utils.FakePlayerEntity
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the handling of onlyDropLootIfKilledByPlayers, then inspect the fake-player classes named in the issue: me.steven.indrev.blockentities.farms.SlaughterBlockEntity and io.github.lucaargolo.kibe.utils.FakePlayerEntity. Verify how kills from those classes are classified and add coverage or validation showing that the configured loot behavior respects them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100