Possible issue with cwms_loc.store_loc2 and external transactions

Open
#233 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Tech stack
visualbasic
Domain
databases

Research direction

Start with cwms_loc.store_loc2 and the linked OpenDCS test-suite changes, then trace how tx.rollback() interacts with the site creation path. Check whether site IDs, existing-site detection, and caches participate in the transaction context. Done means reproducing the failure and identifying a confirmed transaction or caching cause with an appropriate regression test or documented finding.

Written by the indexing model from the issue text.

Description

This may be something else entirely, but opening it now in case similar issues creep up later.

The following OpenDCS test suite uses the linked method to create a list of platforms with Sites to perform it's operations. https://github.com/opendcs/opendcs/pull/2155/changes#diff-39e49efbe7e00d3e10642d1441693f93c3644f254429b264d9b943b3bea59a7aR229

After each test, tx.rollback() is called which should remove anything that was created previously.

I do not see a message that we would be updating an existing site and now errors are thrown on the method (stored procedure) execution. However, the site id is never retrieved.

Now that I type this, it is possible this has something to do with the the various caches as they most likely don't participate in the transaction context.

Dominant language
Visual Basic 6.0
Stars
4
Forks
8
Avg merge
8d 20h
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from HydrologicEngineeringCenter/cwms-database

All issues in HydrologicEngineeringCenter/cwms-database

Similar issues

More Databases issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.