HydrologicEngineeringCenter / HydrologicEngineeringCenter/cwms-data-api-client

Improved OIDC redirect response

Open
#302 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
8
Forks
12
Avg merge
2h 44m
Merged PRs (30d)
3

Description

Currently the way the new AuthCode + PKCE works opens a browser but doesn't close it's tab and move back to the client.
The client can easily grab focus and move to top, and should. However, the redirect handler should provide a useful message to the user if it does not, or just doesn't work.

@krowvin made this for cwms-cli, once it opens the PR and the code is present. We should definitely copy it in and adjust links as appropriate.

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the AuthCode + PKCE redirect handler in this client and review the cwms-cli implementation referenced in the issue once its pull request is available. Confirm the browser flow returns focus to the client, closes the tab when possible, and shows a useful fallback message when it cannot.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
authentication
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.