HydrologicEngineeringCenter / HydrologicEngineeringCenter/cwms-data-api-client
Utilize service provider for "authentication credential lookup"
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 8
- Forks
- 12
- Avg merge
- 2h 44m
- Merged PRs (30d)
- 3
Description
Reading through https://github.com/HydrologicEngineeringCenter/cwms-data-api-client/pull/295, we clearly "assume windows", however CAC can be used in linux, and other methods of certificate auth than smart cards do exist. If we desired to keep this lower level authentication mechanism in place we should utilize the Service Loader or ServerAnnotations to pass the buck to a component that's specific to that implementation and have our client only directly know that it needs a certificate.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pull request #295 and trace the current authentication credential lookup to identify where Windows and smart-card assumptions enter the client. Review the Service Loader and ServerAnnotations options mentioned in the issue. Done means certificate authentication is delegated to an implementation-specific component while the client only depends on the certificate-level contract.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100