HydrologicEngineeringCenter / HydrologicEngineeringCenter/cwms-data-api-client
Improve setup of SSLContexts
A pull request for this has already been merged.
- #280 by @MikeNeilson — merged
- Dominant language
- Java
- Stars
- 8
- Forks
- 12
- Avg merge
- 2h 44m
- Merged PRs (30d)
- 3
Description
Only X509DirectGrantTokenRequestBuilder and CWMSAAA actually require setting up the client certificate.
To get #280 behaving sanely, especially during a test with hec-client-server, I had to rather drastically set SSL* to null as it needed a value but wasn't used, several interfaces also checked for null which somewhat got in the way.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading X509DirectGrantTokenRequestBuilder and CWMSAAA, then trace the SSL* setup and the interfaces that check for null. Use the hec-client-server test context from #280 to determine whether SSLContext values are required or unused; done means certificate setup is limited to the components that need it without null placeholders interfering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, security
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100