HumanSignal / HumanSignal/label-studio

DOMAIN_FROM_REQUEST=True is maybe inconsistent with HOSTNAME handling

Open
#5,704 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
28.3k
Forks
3.7k
Avg merge
14h
Merged PRs (30d)
15

Description

is it me or is this code https://github.com/HumanSignal/label-studio/blob/develop/label_studio/core/settings/base.py#L111-112

clashes with this code just couple lines above
https://github.com/HumanSignal/label-studio/blob/develop/label_studio/core/settings/base.py#L88-93
?

My reading is that if `DOMAIN_FROM_REQUEST=True`
by the time line 111 get's executed, the line 92 or `else` clause on line 93 **guarantee** that 112 will raise an error.

So basically there's no configuration with `DOMAIN_FROM_REQUEST=True` that will not raise on L112.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.