HeroTransitions / HeroTransitions/Hero

Interactive transition documentation

Open
#780 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Swift
Stars
22.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

I don't know if it's the broken documentation, or what, but I can't seem to make Hero work interactively. Does it still work that way?

I was able to find the blog post that is currently a broken link in the documentation in the internet archive here: https://web.archive.org/web/20200415004138/http://lkzhao.com/2017/02/05/hero-interactive-transition.html

Unfortunately, that didn't really help, although it was useful context to have.

I am unclear how Hero works with (or whether it can work with) the `UINavigationController`'s `interactivePopGestureRecognizer` property, but I was able to create a new `UIScreenEdgePanGestureRecognizer` that happens at the same time, and cancel the pop-gesture recognizer when its triggered and I want to use a `Hero` transition instead. The problem is that, once I've started the `Hero` transition using `Hero.shared.start()`, my recognizer's `.changed` case is never called.

I haven't tried reproducing this issue in a simpler stand-alone project, so I don't really know if this is all somehow specific to my codebase, and it very well could be.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.