HeroTransitions / HeroTransitions/Hero

need help, match hero animation across multiple preseting viewcontollers

Open
#766 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
22.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

## What did you do?

My trasition animation process like this:
1. B viewcontroller is in a navigation controller, then presenting I viewcontroller which enable hero and
b.hero.id == i.hero.id, I viewcontroller's modalPresentationStyle is .overCurrentContext
2. after presening, the navigation controller will push a viewcontroller C with subview c, and b.hero.id == i.hero.id == c.hero.id
3. then dismiss I viewcontroller

![image](https://github.com/HeroTransitions/Hero/assets/3890843/ccbef2ec-1a06-4a15-b22c-ad51f663f540)

## What did you expect to happen?

1. when presenting I view controller, b and i will perform match animation
2. after push C view controller, I view controller is presenting over C view controller's content
3. when dismiss I view controller, i and c will perform match animation

## What happened instead?

1. as expected
2. as expected
3. not as expected, C view controller will show subview c, and i and c will perform dismiss transition animation,hero won't remove c from view in animation initial state

## General Information

* Hero Version:

1.6.2

* iOS Version(s):

16.6.1

* Swift Version:

Swift 5

* Devices/Simulators:

iPhone 13 Pro Max

* Reproducible in Examples? (Yes/No):

## Demo Project

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.