HeroTransitions / HeroTransitions/Hero

Request: Make HeroTransition::complete(after: TimeInterval, finishing: Bool) public

Open
#746 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
22.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

This isn't a bug, but a feature request.

Would it be possible to make the `complete(after: TimeInterval, finishing: Bool)` public instead of just `complete(finishing: Bool)`

The main use case I have is when using interactive transitions. If you have a transition thats interactive, and say you finish your gesture when the progress is up to 0.8 or at least there abouts, due to being so 'close' to the end, the animation sometimes feels like it 'snaps' to the finish.

Ideally, I'd like to dynamically alter the duration a bit and allow the animation to take longer to finish that final bit of progress than it would normally do when not interacting.

I tried applying a duration modifier when interacting, but I think totalDuration is only calculated at the start - so maybe the alternative to be able to recalc totalDuration on the fly?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.