HeroTransitions / HeroTransitions/Hero

animations won't work after switching and switching back on tabBarController

Open
#733 1 comment 0 reactions 1 assignee Claimed by @JoeMatt View on GitHub
bug?
Dominant language
Swift
Stars
22.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

## What did you do?

I have a main navigationController in my app that navigates between login page and the main tabBar. the tabBar it self has two child controllers which are both navigationControllers

there is this weird thing with "isHeroEnabled" in the navigationController where if i set it to true in viewDidLoad, hero animations won't work! but if i don't touch it it'll work fine! but that's not the problem!

when the tabbar loads the first page works perfectly fine with all the animations and everything! the problem begins when i switch to next tab and then go back to my first page and find it with no animation! it just awkwardly slides to right to show the next viewController as if hero is not enabled (tho i checked and indeed it was enabled for both vc's and the navigation controller)

## What did you expect to happen?

for animations to work!

## What happened instead?

they did not!

## General Information

* Hero Version: 1.6.1

* iOS Version(s): 13

* Swift Version: 5

* Devices/Simulators: iPhone 13 pro max

* Reproducible in Examples? (Yes/No): yes

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.