HeroTransitions / HeroTransitions/Hero

Hero makes my CAEmitterLayer work inconsistently

Open
#716 5 comments 2 reactions 1 assignee Claimed by @JoeMatt View on GitHub
confirmed bug good first issue need help
Dominant language
Swift
Stars
22.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

## What did you do?

Hi, many thanks to all the people maintaining the library and providing support ❤️.
I use a CAEmitterLayer to make some confettis pop as soon a view is displayed. When Hero is used to transition (with an animation) to the view controller containing the CAEmitterLayer, Confettis will be emitted (that's ok) but when you repeat the process (dismiss the controller then show it again) : Confettis will never be emitted again!
TL:DR : As soon as Hero is used to do something in the app, my CAEmitterLayer will work inconsistently.

## What did you expect to happen?

The CAEmitterLayer emitting confettis every time the view controller is displayed.

## What happened instead?

The CAEmitterLayer will emit confettis the first time the controller is displayed, sometimes the second time and never again!

## General Information

* Hero Version: 1.6.1

* iOS Version(s): 14.4

* Swift Version: 5.3

* Devices/Simulators: All

* Reproducible in Examples? (Yes/No): Yes

## Demo Project

Note : If you deactivate the hero `navigationAnimationType` in the `ViewController`, everything will work as expected.

[caemitterlayerbug.zip](https://github.com/HeroTransitions/Hero/files/6155126/caemitterlayerbug.zip)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.