HeroTransitions / HeroTransitions/Hero

Presented viewController doesnt deinit when dismissing

Open
#693 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
22.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Description

## What did you do?

- Created a new ViewController through storyboard.
- Activated Hero (`isHeroEnabled = true`)
- presented the view through UIKit `present()` method, `animated = true
- Presented correctly`
- Dismissed the view using `Hero.shared.defaultAnimation = .fade` and `hero_dismissViewController()`

## What did you expect to happen?

- The view controller to be dismissed AND removed from memory running the `deinit{}` method

## What happened instead?

- On next presentation, it presents the view controller at the exact same state as before.

## General Information

* Hero Version: 1.5.0

* iOS Version(s): 14.2

* Swift Version: 5

* Devices/Simulators: Simulator (iPhone 8)

* Reproducible in Examples? (Yes/No): No

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.