HenriquesLab / HenriquesLab/VLab4Mic
Change modality parameter pixelsize_nm to take float
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
User can change the pixel size and resolution of the modality they are using to match their experimental set-up, but the precision of the pixel size is limited to 1 nm, whereas in practise it should be ~0.01 nm. When comparing the size of structures from an imaging experiment to a vLab similation, the precision of the pixel size might cause avoidable (?) discrepencies. For example, I would like to compare nanocage size with those generated from simulations of nanocage labelling at varying efficiencies.
Describe the solution you'd like
Would prefer this variable to be a float, instead of an integer.
Describe alternatives you've considered
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Find where the modality parameter pixelsize_nm is defined and how its value is parsed or validated. Update the parameter handling so decimal nanometre values are accepted, then run the relevant project checks to confirm existing integer values still work and fractional values are preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100