HenriquesLab / HenriquesLab/NanoPyx
Was the registration operation used when calculate error_map ?
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 93
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I was using your code to calculate the error map in SQUIRREL algorithm.
I wonder whether the registration operation was used when calculating error map, as I saw the interpolator object was not used at https://github.com/HenriquesLab/NanoPyx/blob/a1fed57628aaf08053b11a09599ae8edc95946b1/src/nanopyx/core/transform/error_map.pyx#L43
Best,
Qiqi Lu
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/nanopyx/core/transform/error_map.pyx at the linked line and trace how the error map is calculated, including whether registration is applied and why the interpolator is unused. Compare the behavior with the SQUIRREL algorithm's expected registration step; done means the discrepancy is resolved and the implementation's behavior is clearly verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100