Helmholtz-AI-Energy / Helmholtz-AI-Energy/propulate
Fix emigration and immigration propagators in `propulator.py` and `pollinator.py`.
Open
@oskar-taubert is already working on this.
Since Aug 25, 2023.
maintenance
- Dominant language
- Python
- Stars
- 46
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
Currently, emigration and immigration propagators are passed down to the actual propagator and pollinator using the class itself and not an actual instance. The respective propagators are repeatedly instantiated before every new migration step. However, propagators should be instantiated only once (in the `__init__`).
This is also related to issue #61.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.