HelloZeroNet / HelloZeroNet/ZeroTalk

Resizable text fields need limits

Open
#89 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
CoffeeScript
Stars
65
Forks
48
PR merge metrics
No merged PRs in 30d

Description

I have some simple recommendations. I could not figure out how development works using git and zites, so I'll just lay it out here.

I believe it looks strange for the `comment_body` and `topic_body` elements to be able to be horizontally resized. It would make sense to set `resize: vertical`. The `topic_body` element is especially messed up on horizontal resize.

It also makes sense to me to set the minimum height of the `textarea`s to the height of a line (24px) plus the paddings (20px) and borders (4px) = 48px, which looks like this:
![image](https://user-images.githubusercontent.com/14015672/57671987-1eb9d800-75e4-11e9-9556-623c7f04b8c7.png)

`comment_body`:
![image](https://user-images.githubusercontent.com/14015672/57671613-84a56000-75e2-11e9-8cbc-2feaf82ca594.png)

`topic_body`:
![image](https://user-images.githubusercontent.com/14015672/57671650-a69ee280-75e2-11e9-9a67-107751caea12.png)

Thanks.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.