HelloZeroNet / HelloZeroNet/ZeroNet

Disable insecure SSL cryptos

Open
#830 5 comments 6 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
18.8k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

The default settings of `ssl` module are not considered the most secure, so Python Software Foundation wrote some [security considerations](https://docs.python.org/2/library/ssl.html#security-considerations).

According to the security considerations, SSLv2 and SSLv3 "are considered insecure and are therefore dangerous to use." The documentation provides a code snippet to disable SSLv2 and SSLv3.

```python
context = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
context.options |= ssl.OP_NO_SSLv2
context.options |= ssl.OP_NO_SSLv3
```

The current SSL patch in ZeroNet redirects `PROTOCOL_SSLv3` to `PROTOCOL_SSLv23` when SSLv3 is not available. Why not redirect `PROTOCOL_SSLv3` and `PROTOCOL_SSLv2` to `PROTOCOL_SSLv23` by default?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.