HelloZeroNet / HelloZeroNet/ZeroNet

Calling mergerSiteDelete doesn't do anything

Open
#1,238 1 comment 1 reaction 1 assignee Claimed by @HelloZeroNet View on GitHub
bug
Dominant language
JavaScript
Stars
18.8k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

### Step 1: Please describe your environment

* ZeroNet version: 0.6.0

### Step 2: Describe the problem:

Calling my `removeMerger` function [here](https://github.com/anoadragon453/ZeroLSTN/blob/master/src/main.js#L137), I get the following output:

```
Removing 15UgXhtcVqf6KTEBVJBkwt5SyKxgcmDDcZ

/* Before */
{…}
/* ... */
14A1qSiNVjcPj1rqBNd49JFJWfHgDvePVU
15UgXhtcVqf6KTEBVJBkwt5SyKxgcmDDcZ // bye bye!
15cwpzZmWmYyGmLFu22FDMKWAfSeAuWbqp
17E4GPZqVnSQSVQEzjiG2JCeLLVwjLvYpR
17izouNc83HLAxASAJfJMr9XW2oLUCH3dH

// mergerSiteDelete called

/* After */
{…}
/* ... */
14A1qSiNVjcPj1rqBNd49JFJWfHgDvePVU
15UgXhtcVqf6KTEBVJBkwt5SyKxgcmDDcZ // Oh, still there? Hrm...
15cwpzZmWmYyGmLFu22FDMKWAfSeAuWbqp
17E4GPZqVnSQSVQEzjiG2JCeLLVwjLvYpR
17izouNc83HLAxASAJfJMr9XW2oLUCH3dH
```

#### Observed Results:

After calling `mergerSiteDelete`, and `mergerSiteList` before and afterwards, the merger site isn't actually deleted, neither from the list, nor the client. It still shows up on ZeroHello.

#### Expected Results:

Ideally the site would be removed from the `mergerSiteList` and site would be deleted from the client, removing it from ZeroHello. I believe this is what the [documentation implies](https://zeronet.readthedocs.io/en/latest/site_development/zeroframe_api_reference/#mergersitedelete-address).

Test it live on the 'genres' tab of [ZeroLSTN](https://zeronet.amorgan.xyz/ZeroLSTN.bit/?/). Edit: Removed due to confusion until this bug is fixed.

Thanks!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.